Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CException is missing a license file #29

Closed
swaldhoer opened this issue Feb 18, 2024 · 6 comments
Closed

CException is missing a license file #29

swaldhoer opened this issue Feb 18, 2024 · 6 comments

Comments

@swaldhoer
Copy link

All other ThrowTheSwitch projects have a dedicate license file

The license for CException is only stated at the end of the README file of the project.

Would it be possible to add a license file to the repository? I think it make sense as it makes the information better accessible and in a more common way.

@mvandervoord
Copy link
Member

Great point. Thanks for noticing!

@swaldhoer
Copy link
Author

@mvandervoord Would you be willing to also include an SPDX identifier to the sources? This would make the creation of an SBOM way simpler and is not really much effort to do that on source side (and on consumer side it creates effort).

Adding SPDX identifiers is simple for licenses like MIT, see https://spdx.dev/learn/handling-license-info.

mvandervoord added a commit that referenced this issue Mar 8, 2024
Fix bug in tests (lack of volatile) (Issue #28)
@mvandervoord
Copy link
Member

@swaldhoer -- I've corrected the license handling. It's now consistent with the other projects.

I looked into the SPDX identifiers. It's a simple process and I definitely see a place for it. The only downside is that the required Linux Foundation membership is rather costly. I'll leave this issue open and can hopefully do this in the future.

@swaldhoer
Copy link
Author

@swaldhoer -- I've corrected the license handling. It's now consistent with the other projects.

perfect, thank you!

I looked into the SPDX identifiers. It's a simple process and I definitely see a place for it. The only downside is that the required Linux Foundation membership is rather costly.

Sorry, I don't understand this point. What is the relation between adding a SPDX identifier to the source code and a required Linux Foundation membership.
Do you mean you need to be a member of the Linux Foundation in order to be allowed to add a SPD identifer to the source code? If so, could you point me to that source? I have never read or heard of that.

@mvandervoord
Copy link
Member

My mistake. I see the important bits of information now. When I first went to the site, it had a popup talking about membership and I assumed that was necessary. Thanks for the followup!

@swaldhoer
Copy link
Author

Fixed in 18d020c and df9af17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants