Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] init_session class method #63

Closed
thenickben opened this issue Jul 24, 2020 · 1 comment
Closed

[BUG] init_session class method #63

thenickben opened this issue Jul 24, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@thenickben
Copy link

Describe the bug
Not quite a bug but I've noticed some policies (like PPO and PG) have an init_session method that is not implemented, yet it's called by the agent (dialog_agent/agent.py) when the pipeline is build. Is this a non-used method or is there any plan of adding something here?
@thenickben thenickben added the bug Something isn't working label Jul 24, 2020
@liangrz15
Copy link
Contributor

The init_session method is used to initialize the attributes of policy, if needed. Rule-based policy does implement this method, while PPO and PG leave this method empty because they don't need to do anything.

@zqwerty zqwerty closed this as completed Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zqwerty @liangrz15 @thenickben