Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up handling of output_dim #1024

Open
4 of 9 tasks
opcode81 opened this issue Jan 16, 2024 · 0 comments
Open
4 of 9 tasks

Clean up handling of output_dim #1024

opcode81 opened this issue Jan 16, 2024 · 0 comments
Labels
refactoring No change to functionality
Milestone

Comments

@opcode81
Copy link
Collaborator

  • I have marked all applicable categories:
    • exception-raising bug
    • RL algorithm bug
    • documentation request (i.e. "X is missing from the documentation.")
    • new feature request
    • design request (i.e. "X should be changed to Y.")
  • I have visited the source website
  • I have searched through the issue tracker for duplicates
  • I have mentioned version numbers, operating system and environment, where applicable:
    import tianshou, gymnasium as gym, torch, numpy, sys
    print(tianshou.__version__, gym.__version__, torch.__version__, numpy.__version__, sys.version, sys.platform)

There are contrived mechanisms for the retrieval of the "output_dim" attribute of nn.Modules in several places (see usages of newly introduced function get_output_dim; there may be others). The clean way of handling this is to change the respective interfaces to a more specfic class that explicitly supports the retrieval of the output dimension. (The high-level API has already partly addressed this by adding corresponding methods to base classes.)

@MischaPanch MischaPanch added the refactoring No change to functionality label Jan 16, 2024
@MischaPanch MischaPanch added this to the Release 1.0.0 milestone Jan 16, 2024
@MischaPanch MischaPanch added this to To do in Overall Tianshou Status via automation Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring No change to functionality
Development

No branches or pull requests

2 participants