Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better interfaces and names for Actor, Critic, Net and other classes #1091

Open
MischaPanch opened this issue Apr 3, 2024 · 0 comments
Open
Assignees
Labels
refactoring No change to functionality

Comments

@MischaPanch
Copy link
Collaborator

All annotations with nn.Module should be replaced. @opcode81 feel free to extend the description, if you want to.

We could make it backwards compatible and use of the deprecation project by doing something like

@deprecated(
    deprecated_in="1.1.0",
    removed_in="2.0.0",
    details="This class has been renamed. Use CriticDiscrete instead",
)
class Critic(CriticDiscrete):
   pass
@MischaPanch MischaPanch added refactoring No change to functionality breaking changes Changes in public interfaces. Includes small changes or changes in keys labels Apr 3, 2024
@MischaPanch MischaPanch added this to To do in Overall Tianshou Status via automation Apr 3, 2024
@MischaPanch MischaPanch removed the breaking changes Changes in public interfaces. Includes small changes or changes in keys label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring No change to functionality
Development

No branches or pull requests

2 participants