Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-examine the need of utils.net.common.DataParallelNet #1094

Open
MischaPanch opened this issue Apr 3, 2024 · 0 comments
Open

Re-examine the need of utils.net.common.DataParallelNet #1094

MischaPanch opened this issue Apr 3, 2024 · 0 comments
Labels
refactoring No change to functionality tentative Up to discussion, may be dismissed
Projects
Overall Tianshou Status

Comments

@MischaPanch
Copy link
Collaborator

It does essentially nothing (just casting to tensor) and obscures interfaces. Can it be removed? Only used in ppo example for some reason

@opcode81 related to our discussion about interface of forward becoming a tensor instead of array | tensor. Wanna look into it?
@MischaPanch MischaPanch added refactoring No change to functionality tentative Up to discussion, may be dismissed labels Apr 3, 2024
@MischaPanch MischaPanch added this to To do in Overall Tianshou Status via automation Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring No change to functionality tentative Up to discussion, may be dismissed
Projects
Overall Tianshou Status
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MischaPanch