Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using sha1 hashes as filenames #60

Closed
juris opened this issue Jun 14, 2016 · 3 comments
Closed

Using sha1 hashes as filenames #60

juris opened this issue Jun 14, 2016 · 3 comments

Comments

@juris
Copy link

juris commented Jun 14, 2016

Would be great to have an option to use digest hash as filenames, as it was with willtrking's version.

As per aws best practices it is not performance efficient with the current schema, when object is stored with its original filename.

@Bladrak
Copy link

Bladrak commented Jun 14, 2016

To comply with the best practices, we should rather suggest that the user uses CloudFront as in http://docs.aws.amazon.com/AmazonS3/latest/dev/request-rate-perf-considerations.html#get-workload-considerations, given the workload should rather be GET-request intensive (as the cache is only written once).

The suggestion of adding an hash as a key prefix (not the full key) is rather for a mix of request types (GET but also PUT/POST/DELETE), which may be the case in some implementations of thumbor, but is rather limited IMO. The option could be added though, for those implementations, to add a hash prefix to the file key.

@dhardy92
Copy link

I suppose UUID key usage on POST requests is enough chaotic.
Problem exists on loader + storage when very heavily used as @Bladrak suggests.

@Bladrak
Copy link

Bladrak commented Sep 29, 2016

Closing this issue as there hasn't been much activity on it. Feel free to re-open if it happens again.

@Bladrak Bladrak closed this as completed Sep 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants