Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Photo Titles #14

Closed
markwk opened this issue Oct 5, 2014 · 3 comments
Closed

Support Photo Titles #14

markwk opened this issue Oct 5, 2014 · 3 comments
Labels
enhancement New feature or functionality

Comments

@markwk
Copy link

markwk commented Oct 5, 2014

I really like what you are doing here. Simple and understandable approach to static photo gallery generation and using nodejs to boot! Bravo!

I'd like to add Title support so that title gets shown for images. I guess the step would be generate some of that info into metadata.json as a new line so we'd end up with something like

"filename.jpg": {
"fileDate": 1412499522000,
"mediaDate": 1408641125000,
"mediaType": "photo",
"title":"title-here-using-filename"
},

@rprieto
Copy link
Member

rprieto commented Oct 5, 2014

Hi Mark, thanks that's great to hear!

Photo titles could be nice. How would you find them? One option could be to read the caption field of the EXIF data, if present. Then yep adding this to metadata.json sounds good, so it's not re-calculated all the time.

@markwk
Copy link
Author

markwk commented Oct 5, 2014

Reading from captions sounds correct with a fallback to use the filename.

@rprieto rprieto added the enhancement New feature or functionality label Oct 8, 2014
@rprieto
Copy link
Member

rprieto commented Oct 14, 2015

Hi @markwk, closing in favour of #24 to have all conversations in one place. We now support EXIF captions, and we can add an option to default to the file name. Thanks for the suggestions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or functionality
Projects
None yet
Development

No branches or pull requests

2 participants