Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code audit: Convert CRLF to LF #1146

Open
Fmstrat opened this issue Feb 24, 2024 · 1 comment
Open

Code audit: Convert CRLF to LF #1146

Fmstrat opened this issue Feb 24, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Fmstrat
Copy link
Contributor

Fmstrat commented Feb 24, 2024

Bug Description

Some of the development files are using CRLF (^M) instead of LF, which can wreak havoc on diffs if someone's editor swaps them.

At a point where there aren't many outstanding PRs, I would recommend doing a full conversion Ala dos2unix on the whole repo. Doing it mid PR will cause any contributor's diffs to get real confusing ;)

Expected Behaviour

Consistent line feeds

Steps to Reproduce

n/a

Additional Context

No response

App Version

No response

Device

n/a

OS

n/a

@Fmstrat Fmstrat added the bug Something isn't working label Feb 24, 2024
@hjiangsu
Copy link
Member

Thanks for the report and nice catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants