Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement search functionality in more areas of the app #1306

Open
1 of 3 tasks
codenyte opened this issue Apr 15, 2024 · 5 comments
Open
1 of 3 tasks

Implement search functionality in more areas of the app #1306

codenyte opened this issue Apr 15, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@codenyte
Copy link

codenyte commented Apr 15, 2024

Is Your Feature Request Related to a Problem?

No response

Feature Description

There are some areas of the app that could really benefit from a search feature. Examples of this are:

  • Comments
    Before I switched from iOS to Android and from Reddit to Lemmy, I used to use the Apollo client for Reddit. I really miss the search feature in the comment section. Just realized that this feature exists, it's just hidden away. Could be improved though.
  • Saved posts
    I also remember this feature from Apollo and I found it to be really useful
  • (Inbox)
    Maybe there could also a search box for the Inbox? This isn't really necessary, but there are some situations in which it might be useful. This one is not as important though.

Alternative Solutions

N/A

Additional Context

I wasn't sure whether to combine these into one issue or to open seperate issues for the search functionality in the individual areas of the app

@codenyte codenyte added the enhancement New feature or request label Apr 15, 2024
@micahmo
Copy link
Member

micahmo commented Apr 15, 2024

Hey @codenyte, thanks for the issue! I think it's ok to have all of these in one. Maybe we can make them into checkboxes in your original post so we can check them off as they're done.

  • search feature in the comment section

I believe this was implemented in #887! Take a look at the video (or try yourself) and let me know if that's what you had in mind!

@codenyte
Copy link
Author

codenyte commented Apr 15, 2024

Damn, I did not realize that this feature exists. It's kinda hidden away, maybe add an option to display a search box at the top of the comment page, similar to Apollo? Is this worth considering?

Edit: It's even more confusing, because I don't see the three dots as can be seen in your screen recording, but instead, I see a reply button. The search button is only revealed when long pressing on the reply button. I find this to be pretty confusing, I don't think I would have ever found this myself.

@micahmo
Copy link
Member

micahmo commented Apr 16, 2024

maybe add an option to display a search box at the top of the comment page, similar to Apollo? Is this worth considering?

Sure, we can definitely try to make it more visible! Do you think it would be visible enough if it were in the overflow menu (three dots) at the top?

I don't see the three dots as can be seen in your screen recording, but instead, I see a reply button. The search button is only revealed when long pressing on the reply button.

Ahh, that's due to the FAB settings. I believe the default is to reply on single press and show the additional options on long press or swipe up. I have mine set to show additional options on single press (hence the three dots). It provides more visibility, but it also removes the ability to perform a single action without multiple taps. The nice thing is that the FAB is super customizable. You can even have separate actions for short and long press, and still access all the additional items with a swipe. Try messing around with these settings! 😊

image

@codenyte
Copy link
Author

Thanks a lot! I now have the Floating Action Button set to work as a search button. For some reason, it doesn't work though. It appears to be a bug? I tap on the FAB (which now has a search icon) and nothing happens. I can only bring up the search by swiping up from the FAB and selecting Search from the menu. Will add a screen recording later.

@micahmo
Copy link
Member

micahmo commented Apr 16, 2024

Wow, nice catch! No need for a video as I can reproduce. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants