Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button to discard read posts from the feed or an "unread only" feed #170

Closed
tunglith opened this issue Jul 2, 2023 · 8 comments
Closed
Assignees
Labels
enhancement New feature or request fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version
Milestone

Comments

@tunglith
Copy link

tunglith commented Jul 2, 2023

Is your feature request related to a problem? Please describe.
When going back to the app after a few hours, the top posts are often the same and require a lot of scrolling to get new stuff. This is not an issue in itself as it's good to see posts rising and to be able to go back to them to see new comments, sometimes we want to get to the new stuff.

Describe the solution you'd like
The initial request is inspired by Relay for Reddit which main central button is used to discard the read posts from the feed. This way when you open the app, even though the feed is still r/all in hot or whatever, the read post (which have a darker background) are discarded and unread posts are brought to the top.

Describe alternatives you've considered
Although I love this feature because it prevents me from scrolling through the same posts every time I open the app, it's not perfect. If you have read a lot of posts, discarding the read posts will force to fetch new posts which can include read posts and the button would have to be clicked again.

An alternative could be a second feed or a toggle (maybe next to the sort options button in the top right) to hide read posts entirely and only get the new stuff ?

Additional context
You'll find a screen record bellow of how the discard button works in relay (speedran to fit into Github's 10Mb limit).

Screenrecorder-2023-07-02-14-38-33-693.mp4
@tunglith tunglith added the enhancement New feature or request label Jul 2, 2023
@Poolitzer
Copy link
Collaborator

An alternative could be a second feed

The issue with adding another feed that feeds right now act as filters (subscribed, local, all), and you might want to have any of these combined with unread. So you would need three more filters which is too much for the left sidebar.

or a toggle (maybe next to the sort options button in the top right) to hide read posts entirely and only get the new stuff ?

I dont like mixing sort by and filter by options in one interface.

In my opinion, we need a new menu, a filter menu. There is still space in the upper menu bar to add one more icon, and then lets filter away.

@hjiangsu
Copy link
Member

hjiangsu commented Jul 2, 2023

An alternative could be a second feed or a toggle (maybe next to the sort options button in the top right) to hide read posts entirely and only get the new stuff ?

Just adding in that this could be tied in with #174 for a filtering button to allow you to quickly toggle different settings in the feed

@Poolitzer
Copy link
Collaborator

Maybe we should rename on of the issues to filter button if you want to go with that and collect what people want to filter. NSFW, already read, etc

@Poolitzer
Copy link
Collaborator

Basically happened in #273 now.

@tunglith
Copy link
Author

tunglith commented Jul 8, 2023

Not sure I get what you mean, we're talking about the main feed not search results ?

@Poolitzer
Copy link
Collaborator

Your issue does, but the last few comments didn't, which I wanted to follow up/close with this.

@Lippiece
Copy link

Ability to filter read posts would be a major victory of this app over the others, imho.

@hjiangsu
Copy link
Member

hjiangsu commented Dec 4, 2023

The ability to hide read posts has been added in this PR: #921

The initial request is inspired by Relay for Reddit which main central button is used to discard the read posts from the feed.

Similarly, this has already been implemented so I'll mark this issue as fixed for next release!

@hjiangsu hjiangsu self-assigned this Dec 4, 2023
@hjiangsu hjiangsu added the fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version label Dec 4, 2023
@hjiangsu hjiangsu added this to the v0.2.7 milestone Dec 4, 2023
@hjiangsu hjiangsu closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version
Projects
None yet
Development

No branches or pull requests

4 participants