Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide menus on downward scroll (/reveal on up-scroll) #74

Open
machinaeZER0 opened this issue Jun 25, 2023 · 6 comments
Open

Hide menus on downward scroll (/reveal on up-scroll) #74

machinaeZER0 opened this issue Jun 25, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request in-progress Indicates that an issue is currently being worked on

Comments

@machinaeZER0
Copy link
Collaborator

Suggestion: an option (perhaps toggleable) to hide the top bar (with the hamburger menu) and bottom bar (with the home button) while scrolling through your feeds. Starting to scroll back up the feed would cause the menus to slide back into view/become accessible again.

I see a fair number of lemmy/reddit apps with this feature, and it feels like a useful thing to implement - the main benefit is that you get a not-insubstantial amount of screen real estate back as you're scrolling, which always feels like a win to me :)

@machinaeZER0 machinaeZER0 added the enhancement New feature or request label Jun 25, 2023
@CTalvio
Copy link
Collaborator

CTalvio commented Jun 25, 2023

Example of the feature in Relay for Reddit.

2023-06-24-18-27-35.mp4

@everdred
Copy link

everdred commented Jul 4, 2023

I understand it may be popular but I'd greatly appreciate it if this could be implemented as a toggle-able option, as one of the most refreshing things I noticed about Thunder is that it doesn't have this behavior. I'm really not a fan of having basic UI elements I might want to glance at or use disappear, and there's just something fundamentally weird to me about how the unconnected act of scrolling up is how you bring back the title, filter and hamburger buttons. Maybe we can both be happy!

@Fmstrat
Copy link
Contributor

Fmstrat commented Jul 5, 2023

For more context, and I think the OP means this, both the top and bottom bars should hide on swipe up and restore on swipe down/reload. When returning to the feed from reading a post, the bars should remain in the state they were when the item was tapped on. I also agree with making this a toggle option (default true).

@hjiangsu
Copy link
Member

hjiangsu commented Jul 5, 2023

Yeah, I'll chime in on this. I think it's best suited to be a toggle!

@hjiangsu
Copy link
Member

hjiangsu commented Jan 8, 2024

This is partially added in with this PR: #1029 for the top app bar. For the bottom navigation bar, there is a lot more work that would be required to get it to work well so that is on-hold for the future.

See the PR for a video example of how it works!

@hjiangsu hjiangsu added the in-progress Indicates that an issue is currently being worked on label Jan 8, 2024
@hjiangsu hjiangsu self-assigned this Jan 8, 2024
@machinaeZER0
Copy link
Collaborator Author

Heck yes!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in-progress Indicates that an issue is currently being worked on
Projects
None yet
Development

No branches or pull requests

5 participants