Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of jQuery #1317

Closed
3 tasks done
Standard8 opened this issue Oct 20, 2018 · 5 comments
Closed
3 tasks done

Remove usage of jQuery #1317

Standard8 opened this issue Oct 20, 2018 · 5 comments
Assignees

Comments

@Standard8
Copy link
Collaborator

Standard8 commented Oct 20, 2018

Per previous discussions and especially a couple of comments on bugs, we should move away from using jQuery in conversations.

There's probably several parts to this:

  • The gallery view (content/gallery)
  • The setup assistant (content/assistant)
  • The message pane (content/stub.xhtml & co)
@Standard8
Copy link
Collaborator Author

Note: I'm currently looking into removing jQuery from the assistant.

@Standard8
Copy link
Collaborator Author

#1333 is looking at removing jQuery from the gallery.

@Standard8
Copy link
Collaborator Author

#1345 is the start of the rewrite for stub.xhtml. There's a long way to go, but it has started.

@Standard8
Copy link
Collaborator Author

Status update: a few parts of the conversation view are now based on react - the conversation header and footer, some of the message header, and the attachments display (and a couple of other minor parts). These are getting things working again for 68, though there's a few bugs now.

That's given me enough proof of concept that I'm now working on a larger rewrite of the whole conversation view dropping jquery and replacing the templating mechanism we had there.

I'm not sure the eta for this work - I currently have a few basic items on the messages being displayed, but there's a lot more to do, will post an update or branch when I can.

@Standard8
Copy link
Collaborator Author

I've just pushed the switch of the message list to React onto the master branch. It isn't quite complete yet (I'll file more issues in a moment), but it has now removed jQuery. Hence calling this done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant