Ringtone settings gets disabled after rotating the device

[rezazarchi]

Checklist

• I have used the search function to see if someone else has already submitted the same bug report.
• I will describe the problem with as much detail as possible.

App version

6.713

Where did you get the app from?

F-Droid

Android version

14

Device model

Samsung Galaxy S23 Ultra

Steps to reproduce

1. Go to your account settings
2. Go to Notifications
3. Select "New mail ringtone
4. In the opened window, rotate the device
5. press the back button
6. scroll down to see the "New mail ringtone" and other two related options

Expected behavior

We should see them enabled and we could click on them again.

Actual behavior

"New mail ringtone" and "Vibration" and "Notification light" are disabled

Logs

No response

Video

device-2024-01-02-114716.mp4

[rezazarchi]

@cketti
Why did you disable the preference here?

...
findPreference<NotificationSoundPreference>(PREFERENCE_NOTIFICATION_SOUND)?.let { preference ->
                notificationSoundPreference = preference
                preference.isEnabled = false
            }
...

[cketti]

At the time initializeNotifications() is called, Account.notificationSettings might contain outdated information. The current values are read from the NotificationChannel in updateNotificationPreferences().

[rezazarchi]

At the time initializeNotifications() is called, Account.notificationSettings might contain outdated information. The current values are read from the NotificationChannel in updateNotificationPreferences().

Thanks for your answer but i didn't get how they are related to that line? How we can avoid this issue when returning to the AccountSettingsFragment from the rotated Ringtone manager activity ?

[cketti]

@rezazarchi: Can you test the fix in #7469?

[rezazarchi]

@rezazarchi: Can you test the fix in #7469?

I checked this pull request and tested it on my Galaxy phone and verified that the issue has been resolved. Thank you.