Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New action editor shortcut overrides a basic VS Code key binding #451

Closed
ihouwat opened this issue Jan 26, 2022 · 10 comments
Closed

New action editor shortcut overrides a basic VS Code key binding #451

ihouwat opened this issue Jan 26, 2022 · 10 comments
Labels
feature request New feature or request

Comments

@ihouwat
Copy link

ihouwat commented Jan 26, 2022

User experience issue
The latest update adds a key binding of Ctrl+Shift+t to access Thunder Client in the action bar. Unfortunately, this overrides a pretty basic VS Code shortcut to reopen a previously closed editor - which incidentally is the same shortcut implemented in Chrome, Edge, Firefox browsers as well.

Solution I'd like
The shortcut for action bar is a great idea, but can we have a shortcut that doesn't clash with such a basic and simple native one. Sure, I can override, but I don't want to have to do it.

Alternative?
Maybe ctrl+k ctrl+shift+t, since it doesn't clash with workbench, but I don't know how that impacts other extensions.

@ihouwat ihouwat added the feature request New feature or request label Jan 26, 2022
@rangav
Copy link
Collaborator

rangav commented Jan 26, 2022

Thanks @ihouwat for the feedback, will review if there is a better shortcut keys.

@rangav
Copy link
Collaborator

rangav commented Jan 26, 2022

what about ctrl+shift+R shortcut key? its not used in vscode shortcuts list

https://code.visualstudio.com/shortcuts/keyboard-shortcuts-windows.pdf

@ihouwat
Copy link
Author

ihouwat commented Jan 26, 2022

what about ctrl+shift+R shortcut key? its not used in vscode shortcuts list

https://code.visualstudio.com/shortcuts/keyboard-shortcuts-windows.pdf

I see it in 3 places in the keybindings, one for refactoring and a couple for searching/navigating.

For some reason, I can't paste a screenshot... But you can find it if you search for "Open Default Keyboard Shortcuts (JSON)" in the Command Palette inside of VS Code.

To be fair, there'll be a shortcut for almost anything! 🤷 Is it too much to do two keypress actions?

@rangav
Copy link
Collaborator

rangav commented Jan 26, 2022

Yeah two key press action is complicated, most people will ignore.

and also the other windows in sidebar start with ct+sh+someKey shortcut keys, so it's better to follow same pattern

@rangav rangav pinned this issue Jan 26, 2022
@ihouwat
Copy link
Author

ihouwat commented Jan 26, 2022

Yeah two key press action is complicated, most people will ignore.

and also the other windows in sidebar start with ct+sh+someKey shortcut keys, so it's better to follow same pattern

Got it. I guess, I'd be thrilled with the new one you suggested, but someone else might complain 😂

@rangav
Copy link
Collaborator

rangav commented Jan 27, 2022

This bug is now fixed in v1.11.1, Just now published new quick release.

The new shortcut is ctrl+shift+R

please let me know if any feedback

@rangav rangav closed this as completed Jan 27, 2022
@ihouwat
Copy link
Author

ihouwat commented Jan 27, 2022

Thanks for the quick response!

@rangav rangav unpinned this issue Jan 27, 2022
@iqfareez
Copy link

iqfareez commented Jan 31, 2022

Hi. The new shortcut ctrl+shift+R overrides the refactor shortcut (or the yellow bulb things), which impacts my workflow.

Is there any way to change the keybinds to something else? Thx!

@rangav
Copy link
Collaborator

rangav commented Jan 31, 2022

Hi @iqfareez, open keyboard shortcuts from command pallete and you can modify the keys

@iqfareez
Copy link

@rangav, problem solved. Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants