Method getParameter returns value with quotes

[drmzio]

Parameter values using double quotes get passed back with double quotes when using getParameter. Maybe there's a way to modify this configuration to strip double quotes?

Environment

• PHP v7.2
• Shortcode v0.6.5

$handlers = new HandlerContainer();
$handlers->add('hello', function (ShortcodeInterface $s) {
    return sprintf('Hello, %s', $s->getParameter('name'));
});
$processor = new Processor(new WordpressParser(), $handlers);
return $processor->process($input);

This example shows two of the same shortcodes: one with double quotes for the parameter value and one without.

[thunderer]

Hi @drmzio, you're using WordpressParser which works exactly like WordPress. As noted in the class header, it is meant only as a compatibility layer if you need exactly the same behavior. Did anything change in WordPress that would require an update to this parser?

I recommend you to try the latest library version v0.7.1 with RegularParser. Does it work correctly for your use case?

[thunderer]

@drmzio By the way, I tested all parsers with the latest version of the library using PHP 7.2, and none of them result in the reported behavior. Could you please tell me what is the output of this code in your environment?

<?php
declare(strict_types=1);
namespace X;

use Thunder\Shortcode\HandlerContainer\HandlerContainer;
use Thunder\Shortcode\Parser\RegexParser;
use Thunder\Shortcode\Parser\RegularParser;
use Thunder\Shortcode\Parser\WordpressParser;
use Thunder\Shortcode\Processor\Processor;
use Thunder\Shortcode\Shortcode\ShortcodeInterface;

require __DIR__.'/vendor/autoload.php';

$handlers = new HandlerContainer();
$handlers->add('hello', function (ShortcodeInterface $s) {
    return sprintf('Hello, %s', $s->getParameter('name'));
});

$input = '[hello name="Daniel"] [hello name=John]';
echo (new Processor(new RegexParser(), $handlers))->process($input)."\n";
echo (new Processor(new RegularParser(), $handlers))->process($input)."\n";
echo (new Processor(new WordpressParser(), $handlers))->process($input)."\n";

[drmzio]

@thunderer Trying out the code above outputs:

Hello, Daniel Hello, John
Hello, Daniel Hello, John
Hello, Daniel Hello, John

So after further inspection, found out that the Markdown editor was the one escaping quotes. Since this issue isn't related to Shortcode itself, I'm closing this. Thanks for the help!

[thunderer]

No problem, I'm happy that it works for you, @drmzio!