Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up some less-than-stellar python in this project #1

Open
thundergolfer opened this issue Feb 27, 2018 · 2 comments
Open

Clean up some less-than-stellar python in this project #1

thundergolfer opened this issue Feb 27, 2018 · 2 comments
Labels
good first issue

Comments

@thundergolfer
Copy link
Owner

There's some sloppy programming in here. Just before saw that I was calling len(something) around 5 times for the same something variable in one function.

Go through and clean up bad code like the above, and anything that's not idiomatic python.
@trevorgor289
Copy link

hi, is this still something I can work on?

@thundergolfer
Copy link
Owner Author

Sure! I'll accept PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thundergolfer @trevorgor289