Updated levels of some internal debug logs to error level

thundra-io · May 31, 2020 · a0c07fe · a0c07fe
1 parent f4bfb47
commit a0c07fe
Show file tree

Hide file tree

Showing 7 changed files with 28 additions and 13 deletions.
diff --git a/src/Reporter.ts b/src/Reporter.ts
@@ -159,10 +159,21 @@ class Reporter {
                         this.latestReportingLimitedMinute = Math.floor(Date.now() / 1000);
                     }
                     if (response.statusCode !== 200) {
-                        ThundraLogger.getInstance().debug(JSON.stringify(this.reports));
-                        return reject({ status: response.statusCode, data: responseData });
+                        // First, check whether or debug is enabled.
+                        // If not no need to convert reports into JSON string to pass to "debug" function
+                        // because "JSON.stringify" is not cheap operation.
+                        if (ThundraLogger.getInstance().isDebugEnabled()) {
+                            ThundraLogger.getInstance().debug(JSON.stringify(this.reports));
+                        }
+                        return reject({
+                            status: response.statusCode,
+                            data: responseData,
+                        });
                     }
-                    return resolve({ status: response.statusCode, data: responseData });
+                    return resolve({
+                        status: response.statusCode,
+                        data: responseData,
+                    });
                 });
             };
 

diff --git a/src/ThundraLogger.ts b/src/ThundraLogger.ts
@@ -3,19 +3,23 @@ import ConfigNames from './config/ConfigNames';
 
 class ThundraLogger {
     static instance: ThundraLogger;
-    enabled: boolean;
+    debugEnabled: boolean;
 
     constructor() {
-        this.enabled = ConfigProvider.get<boolean>(ConfigNames.THUNDRA_DEBUG_ENABLE);
+        this.debugEnabled = ConfigProvider.get<boolean>(ConfigNames.THUNDRA_DEBUG_ENABLE);
         ThundraLogger.instance = this;
     }
 
     static getInstance(): ThundraLogger {
         return ThundraLogger.instance ? ThundraLogger.instance : new ThundraLogger();
     }
 
+    isDebugEnabled(): boolean {
+        return this.debugEnabled;
+    }
+
     debug(message: any) {
-        if (this.enabled) {
+        if (this.debugEnabled) {
             console.log(message);
         }
     }
@@ -29,7 +33,7 @@ class ThundraLogger {
     }
 
     toggle() {
-        this.enabled = !this.enabled;
+        this.debugEnabled = !this.debugEnabled;
     }
 }
 

diff --git a/src/ThundraWrapper.ts b/src/ThundraWrapper.ts
@@ -374,7 +374,7 @@ class ThundraWrapper {
                     }
                 })
                 .catch((error) => {
-                    ThundraLogger.getInstance().debug(error);
+                    ThundraLogger.getInstance().error(error);
                     // There is an error on "before-invocation" phase
                     // So skip Thundra wrapping and call original function directly
                     const result = this.originalFunction.call(

diff --git a/src/opentracing/Span.ts b/src/opentracing/Span.ts
@@ -126,7 +126,7 @@ class ThundraSpan extends Span {
         this.tags[key] = keyValuePairs[key];
       });
     } catch (e) {
-      ThundraLogger.getInstance().debug(e);
+      ThundraLogger.getInstance().error(e);
     }
   }
 

diff --git a/src/opentracing/instrument/Instrumenter.ts b/src/opentracing/instrument/Instrumenter.ts
@@ -63,7 +63,7 @@ class Instrumenter {
                         content = content.substring(Module.wrapper[0].length, content.length - Module.wrapper[1].length);
                     }
                 } catch (ex) {
-                    ThundraLogger.getInstance().debug(ex);
+                    ThundraLogger.getInstance().error(ex);
                 }
             }
             self.origCompile.call(this, content, filename);

diff --git a/src/plugins/integrations/AWSIntegration.ts b/src/plugins/integrations/AWSIntegration.ts
@@ -303,7 +303,7 @@ class AWSIntegration implements Integration {
                 span.setTag(SpanTags.TRACE_LINKS, traceLinks);
             }
         } catch (error) {
-            ThundraLogger.getInstance().debug(`Error while injecting trace links, ${error}`);
+            ThundraLogger.getInstance().error(`Error while injecting trace links, ${error}`);
         }
     }
 
@@ -559,7 +559,7 @@ class AWSIntegration implements Integration {
                                     request.params.ClientContext = Buffer.from(
                                         JSON.stringify({ custom: clientContext })).toString('base64');
                                 } catch (err) {
-                                    ThundraLogger.getInstance().debug('Cannot parse lambda client context not a valid JSON');
+                                    ThundraLogger.getInstance().error('Cannot parse lambda client context not a valid JSON');
                                 }
                             } else {
                                 request.params.ClientContext = Buffer.from(JSON.stringify({ custom })).toString('base64');

diff --git a/src/plugins/integrations/HttpIntegration.ts b/src/plugins/integrations/HttpIntegration.ts
@@ -178,7 +178,7 @@ class HttpIntegration implements Integration {
                                     }
                                     span.setTag(HttpTags.BODY, lines[lines.length - 1]);
                                 } catch (error) {
-                                    ThundraLogger.getInstance().debug(error);
+                                    ThundraLogger.getInstance().error(error);
                                 }
                             }
                         }