Merge pull request #83 from getsentry/expand-tests

Fixes + Tests

conftest.py

@@ -3,3 +3,8 @@
 pytest_plugins = [
     'sentry.utils.pytest'
 ]
+
+
+def pytest_configure(config):
+    from django.conf import settings
+    settings.INSTALLED_APPS += ('sentry_jira',)

sentry_jira/forms.py

@@ -1,4 +1,7 @@
+from __future__ import absolute_import
+
 import logging
+
 from django.core.exceptions import ValidationError
 from django.utils.translation import ugettext_lazy as _
 from django import forms
@@ -175,6 +178,7 @@ def clean(self):
                                           " to enter a CAPTCHA in JIRA to re-enable API"
                                           " logins." % e.status_code)
                 else:
+                    logging.exception(e)
                     raise ValidationError("Unable to connect to JIRA: Bad Response")
             if not sut_response.json:
                 raise ValidationError("Unable to connect to JIRA: Bad Response")
@@ -206,7 +210,7 @@ class JIRAIssueForm(forms.Form):
     )
 
     def __init__(self, *args, **kwargs):
-        self.ignored_fields = kwargs.pop("ignored_fields")
+        self.ignored_fields = set((kwargs.pop("ignored_fields") or '').split(","))
         initial = kwargs.get("initial")
         jira_client = kwargs.pop("jira_client")
         project_key = kwargs.pop("project_key")
@@ -228,7 +232,7 @@ def __init__(self, *args, **kwargs):
             return
 
         # Early exit #2, no projects available.
-        if len(meta["projects"]) is 0:
+        if len(meta["projects"]) == 0:
             super(JIRAIssueForm, self).__init__(*args, **kwargs)
             self.errors["__all__"] = [
                 "Error in JIRA configuration, no projects found for user %s.".format(jira_client.username)
@@ -270,7 +274,7 @@ def __init__(self, *args, **kwargs):
         dynamic_fields.sort(key=lambda f: anti_gravity.get(f) or 0)
         # build up some dynamic fields based on required shit.
         for field in dynamic_fields:
-            if field in self.fields.keys() or field in [x.strip() for x in self.ignored_fields.split(",")]:
+            if field in self.fields.keys() or field in [x.strip() for x in self.ignored_fields]:
                 # don't overwrite the fixed fields for the form.
                 continue
             mb_field = self.build_dynamic_field(self.issue_type["fields"][field])

sentry_jira/jira.py

@@ -2,7 +2,7 @@
 
 import logging
 
-from requests.exceptions import RequestException
+from requests.exceptions import ConnectionError, RequestException
 from sentry.http import build_session
 from sentry.utils import json
 from sentry.utils.cache import cache
@@ -140,8 +140,12 @@ def make_request(self, method, url, payload=None):
                 r = session.post(
                     url, json=payload, auth=auth,
                     verify=False, timeout=self.HTTP_TIMEOUT)
+        except ConnectionError as e:
+            raise JIRAError(unicode(e))
         except RequestException as e:
             resp = e.response
+            if not resp:
+                raise JIRAError('Internal Error')
             if resp.status_code == 401:
                 raise JIRAUnauthorized.from_response(resp)
             raise JIRAError.from_response(resp)

sentry_jira/plugin.py

@@ -325,8 +325,14 @@ def post_process(self, group, event, is_new, is_sample, **kwargs):
         if not (default_priority and default_issue_type and default_project):
             return
 
+        jira_client = self.get_jira_client(group.project)
+        meta = jira_client.get_create_meta(default_project).json
+        if not meta or len(meta["projects"]) == 0:
+            return
+        project = meta["projects"][0]
+
         post_data = {
-            'project': {'id': default_project},
+            'project': {'id': project},
             'summary': initial['summary'],
             'description': initial['description'],
         }