Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PreviousInterval shoud be an integer not double #3

Closed
tomaszsluszniak opened this issue May 14, 2020 · 0 comments · Fixed by #4
Closed

PreviousInterval shoud be an integer not double #3

tomaszsluszniak opened this issue May 14, 2020 · 0 comments · Fixed by #4

Comments

@tomaszsluszniak
Copy link
Contributor

According to the readme, previousInterval should be an integer, not double.

sm2/lib/sm.dart

Line 7 in 4e773fd

double previousInterval,

And there is also a bug in example:

    SmResponse smResponse = sm.calc(
      quality: 0,
      repetitions: 0,
      previousInterval: 2.5,
      previousEaseFactor: 0
    );

default value for previousInterval should be zero, and previousEaseFactor should be 2.5 not zero.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix argument type and tests
1 participant
@tomaszsluszniak