feat(deps): extend version support range to Angular 17 #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thank you! Update: Angular 17 is slated for release on November 8th but we have some things to do in Nx so could you please release a version before that? 🤞 |
|
should be out now :) |
|
Fantastic, thank you so much! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Angular 17 is being released sometime this week (Week of November 6th, 2023). This PR allows for users to install
jest-preset-angularwithout gettingpeerDependencyerrors which cause some package managers to fail the install process.Test plan
We've tested
jest-preset-angular+ Angular 17 as part of the Angular 17 support for Nx and everything works other than a peer dependency error.Does this PR introduce a breaking change?
Other information