Fix TS5 + ESM hang; and upgrade dev dependencies to ng17 #2197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update appears to fix thymikee#2138. It builds with TS 5, and all tests and example tests pass. fixes: [Bug]: ESM with TypeScript >= 5.0 hangs forever thymikee#2138
|
Something is wrong with lock file, would you please check? The rest LGTM |
Husky is required by the postinstall script, but was previously missing.
Tests pass, and example tests pass. resolves: [Feature]: Angular 17 support thymikee#2196
johncrim
force-pushed
the
fix/2138-ts5-hang
branch
from
1ed890e
to
5f3effb
Compare
|
@ahnpnl - I had to add Thanks for the review + guidance. |
|
Would you please also add eslint comments to bypass several |
|
I can confirm that these updates work as expected on our projects using TS 5.2.2 and ng 17.0.8 and ng 17.0.9. |
ahnpnl
approved these changes
Jan 3, 2024
|
Thanks! |
|
Happy to help! Thank you! |
|
Great work on this change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I attempted to fix #2138, and as a side effect also upgrade to ng 17, resolving #2196. The main fixes were adding/improving the typescript version detection and version bridging functions so that the breaking changes in TS 5 (that I'm aware of) are handled, without changing the current level of backward compatibility with older versions of typescript and angular.
Test plan
yarn testandyarn test-examplesall pass (locally).Tomorrow I will upgrade our projects to ng 17 and TS 5 to verify that our tests no longer hang, as described in #2138.
Does this PR introduce a breaking change?
Should not be breaking - I did my best to preserve the existing level of backward compatibility.
Other information
fixes: #2138
resolves: #2196