New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DIO 8 #28
Conversation
- better handle children as props pattern - always convert `tabIndex` attribute to lowercase in server render - handle recursive error in error boundaries - insure root node is passed to componentWillUnmount lifecycle - more tests
Changes Unknown when pulling 8ae3e87 on V8 into ** on master**. |
Agreed. I think we are finally close to a release. Did you find any other hiccups? |
Changes Unknown when pulling 99f3672 on V8 into ** on master**. |
I'm working on a safari mobile diffing issue, but I say go ahead and cut a release-candidate. Some high-level API notes: |
Changes Unknown when pulling 05abc71 on V8 into ** on master**. |
Hydration related? |
…viroment doesn't break exports - add tests for rendering to fragment and handling duplicate keys
Changes Unknown when pulling 28e17c4 on V8 into ** on master**. |
Changes Unknown when pulling d845bcf on V8 into ** on master**. |
Changes Unknown when pulling b076cab on V8 into ** on master**. |
Changes Unknown when pulling 1ec562e on V8 into ** on master**. |
8.0.0-beta.0 deployed at https://gwent.io and https://deckswap.com |
Changes Unknown when pulling bbcba6a on V8 into ** on master**. |
Are they both server rendered? |
The last commit did not include new/updated tests? And yes, though note I'm using dio.js as the backend for Zorium (dio branch) which uses a component instance model that guarantees state persistence across DOM tree manipulation (fundamentally different from React) For server-side rendering I crawl the vtree to fill state before stringification, and bail if too slow. (untilStable()) |
No, nothing changed that would requires new/updated tests. I think the last point to settle on before release is whether to include the renderer package in the next minor release or with the 8.0 release. |
Because it opens up such a large public API, it might be best to let 8.0 settle a bit before introducing it |
Changes Unknown when pulling d3bbe6c on V8 into ** on master**. |
I agree, lets settle with that. |
Ready for the most part, mostly tweaking the level of abstractions to allow for a clean transition into the 2-phase commit->flush approach for the next minor release before/when react fiber(async mode) is released and cooperative scheduling is proven a necessary abstraction.
Currently the infrastructure looks like
reconcile -> commit -> renderer
.The transition would make it look like
reconcile -> commit ... [DOM/Native...]renderer(commits)
.