Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is fit working? #3

Closed
rafaelrenanpacheco opened this issue Sep 29, 2016 · 3 comments
Closed

Is fit working? #3

rafaelrenanpacheco opened this issue Sep 29, 2016 · 3 comments

Comments

@rafaelrenanpacheco
Copy link

Hi there!

It's great to have alternatives for css tooltips, and this wenk looks a good one 馃憤

So, the first step to know a new component is to open the demo site, and see how it works. But I guess something is wrong with the fit option, which in my opinion should be the default option. I don't recall seeing any tooltips with blank spaces.

And after hovering it, this was the result:

fit

It is saying that it fits, but it doesn't.

I'm testing using Chrome 53.

Best regards,
Rafael Pacheco.

@jackmcpickle
Copy link
Collaborator

I believe its meant to fit its parent text.

See this PR #4 for something more along the lines of what you want.

@rafaelrenanpacheco
Copy link
Author

Perfect @jackmcpickle 馃憤

In order for this wenk be production ready, the auto width must be the default option.

Thank you for your help!

@tiaanduplessis
Copy link
Owner

@rafael-renan-pacheco I just realized how confusing the naming actually is. Finishing off some work stuff then I'm going to take a look at #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants