Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home page #22

Merged
merged 4 commits into from Aug 10, 2022
Merged

Home page #22

merged 4 commits into from Aug 10, 2022

Conversation

basitali111
Copy link
Collaborator

You should build these interfaces:
-The home page.
-When the page loads, the webapp retrieves data from:
-The selected API and shows the list of items on screen.

Copy link
Owner

@tiagomarin tiagomarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job so far!
There are some issues that you still need to work on to go to the next step of the project so I can't approve this PR.

Alt Text

Highlights

✔️ Good html organization and syntax use
✔️ No linter errors
✔️ All functionalities for this part of the project is working great.
✔️ Elements are put correctly into the DOM

Required Changes ♻️

  • According to the requirement we need to use ES6 modules, so you could put your functions in separated files. I recommend to put the loadMeal function in one separate file and return mealArray and send this info to another file with the DOM manipulation, it's normally better to keep the DOM manipulation separately from other functions. You could create another function to put the foreach (dom manipultation) for example.

You can try to do as I recommended, but feel free to do another way. After applying the changes, let me know. Also let me know if you have any questions!

Thanks for putting hard work into the code!

Copy link
Owner

@tiagomarin tiagomarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Approved 👏

Great job @basitali111 , thanks for putting effort to make our code the best we can 💙

Highlights
heavy_check_mark Used ES6 modules to organize the code.

@basitali111 basitali111 merged commit fd4d05b into dev Aug 10, 2022
@tiagomarin tiagomarin deleted the home-page branch August 10, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants