Details page #23
Merged
Details page #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basitali111
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
Status: Approved 🟢🟢🟢
Hi @Tiago-Lelinski-Marin,
Your project is complete! There is nothing else to say other than... it's time to merge it: ship it:
Congratulations! 🎉
To highlight o your good work :
✅ Used Gitflow correctly
✅ All linter checks passed
✅ Good descriptive PR
✅ data is fetched as expected for popup of comment 👍
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request I added the functionality to the recipe button, so whenever the user clicks on the button, a modal opens up showing more details regarding the meal.
It displays:
I tried to separate my functions into modules, and leave the DOM manipulation on a separate file, renderPopUp.js.