Add calculation functionality to calculator #4
Conversation
There was a problem hiding this comment.
Hi @Tiago-Lelinski-Marin ,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- Good use of gitflow ✔️
- Descriptive PR ✔️
- No linters errors ✔️
- Great project implementation ✔️
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me (@codecaiine) in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
src/components/Calculator.js
Outdated
| <input type="button" className="btn" value="." /> | ||
| <input type="button" className="btn operator" value="=" /> | ||
| <input type="text" name="input" className="btn input" id="input" value={next || total} /> | ||
| <input onClick={this.onClickHandler} type="button" className="btn" value="AC" /> |
There was a problem hiding this comment.
-
Good job so far with your project implementation it is great 👍 But I can't perform "AC" operation I'm getting errors 😢 , Please fix it in order to make your calculator works as expected 😄
-
One more thing I'm getting the error in the console "You provided a value prop to a form field without an onChange handler" this error occurs generally when we set a value prop on a field that has no onChange handler. I suggest you use the defaultValue prop or set an onChange prop on the field. Please fix it to make your project completed. 👍
There was a problem hiding this comment.
@codecaiine Thanks a lot for your time!
There was a problem hiding this comment.
Hi @Tiago-Lelinski-Marin ,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
✔️ Good commit history
✔️Linters are passing
✔️Very professional README
✔️Correct Git flow
✔️Descriptive PR
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
In this pull request I added the calculation functionality for the user by: