Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring support to fast_jsonapi #83

Open
tiagopog opened this issue Feb 2, 2018 · 9 comments
Open

Bring support to fast_jsonapi #83

tiagopog opened this issue Feb 2, 2018 · 9 comments
Assignees

Comments

@tiagopog
Copy link
Owner

tiagopog commented Feb 2, 2018

Netflix recently released a blazing fast JSON:API serializer which seems to be a very suitable choice for jsonapi-utils.

Although it will require a deep change in the JU's structure, the perfomance gains for serialization are quite impressive:

I still need to take some time to get through the fast_jsonapi's code and then I may start planning the migration from the old serializer (jsonapi-resource) to this new one.

For more information see the Netflix's article.

@tiagopog tiagopog self-assigned this Feb 2, 2018
@GCorbel
Copy link

GCorbel commented Feb 17, 2018

It would be awesome ! I hope perf will be improve as they said.

@g13ydson
Copy link

Hello @tiagopog , have you started this change? I found this gem very cool and I'm thinking of modifying it to support fast_json_api

@tiagopog
Copy link
Owner Author

Hey there, @g13ydson. I haven't started working on this feature yet but I'm really excited to do or to guide someone on doing so though.

It will require major changes on the gem's design, but if you're in we can't start defining its new architecture.

@BatuhanW
Copy link

@tiagopog Is there any update about this? I would like to work on this one.

@tiagopog
Copy link
Owner Author

@BatuhanW Sorry for the delay on answering you. I'm had a period of absence here due to some personal issues, but I'm getting back on track with the gem.

So far, there's no implementation (on my side) regarding this support to fast_jsonapi, but I really want to go ahead with it and would love to have someone from the community working on it.

So, let's do it?

@copasetickid
Copy link

@tiagopog are you still looking for help from the community to work on this feature?

I'd like to help as I'm currently using Netflix's fast_jsonapi for serialization in a project but I would use this instead because this gem provides support for request validation and params helpers built-in.

@tiagopog
Copy link
Owner Author

Hey, @copasetickid. Yes, I'm still looking for someone willing to bring support for this feature. Let me know if you want to do so and if you need any help to start working on that :-)

@copasetickid
Copy link

Hi @tiagopog yes, I would like to help with this effort. Does your offer still stand to help guide someone on doing so though? I'm happy to get started if you already had a plan in mind

@tiagopog
Copy link
Owner Author

@copasetickid I haven't work on a plan for that yet. Actually, the last iterations I had here were all regarding minor fixes and improvements. Since I will be done with a huge private project next week, I'm planning to get back and work on some of open issues/PRs from this gem.

For this one, specifically, we can start understanding where we can take advantage of fast_jsonapi's features and which features we will need to reimplement for leaving jsonapi-resources.

We can try making an effort and iterate at least once a day here or maybe use Telegram or something for doing so. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants