Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native WebSocket should be used in browser environments #33

Closed
tiagosiebler opened this issue Nov 11, 2020 · 0 comments · Fixed by #45
Closed

Native WebSocket should be used in browser environments #33

tiagosiebler opened this issue Nov 11, 2020 · 0 comments · Fixed by #45
Milestone
typescriptv1

Comments

@tiagosiebler
Copy link
Owner

Reported in telegram. The WebSocket client uses the npm ws module, which is not browser compatible.

One possibility is a wrapper approach, such as the one suggested in the ws docs too:
https://github.com/heineiuo/isomorphic-ws
@tiagosiebler tiagosiebler added this to the typescriptv1 milestone Nov 17, 2020
This was referenced Dec 8, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
typescriptv1
Development

Successfully merging a pull request may close this issue.

TypeScript Introduction tiagosiebler/bybit-api
Typescript introduction tiagosiebler/bybit-api
1 participant
@tiagosiebler