Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP client can be configurate outside the SOAP module. #44

Merged
merged 7 commits into from Jun 17, 2020

Conversation

highercomve
Copy link
Contributor

@highercomve highercomve commented Dec 9, 2019

Using an external HTTP Client allows the users to have more control over how he communicates with the service.

For example, adding certificates to the transport configuration.

httpClient := &http.Client{
  Transport: &http.Transport{
    TLSClientConfig: &tls.Config{
      InsecureSkipVerify: true,
    },
  },
}

soapClient := gosoap.SoapClient(url, httpClient)

And any kind of configuration for the HTTP Client will apply even though when the library is getting the definitions.

@codecov-io
Copy link

codecov-io commented Dec 9, 2019

Codecov Report

Merging #44 into master will decrease coverage by 0.21%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   71.37%   71.16%   -0.22%     
==========================================
  Files           5        5              
  Lines         262      267       +5     
==========================================
+ Hits          187      190       +3     
- Misses         63       64       +1     
- Partials       12       13       +1
Impacted Files Coverage Δ
encode.go 64.75% <ø> (ø) ⬆️
response.go 50% <ø> (ø) ⬆️
request.go 75% <ø> (ø) ⬆️
wsdl.go 100% <100%> (ø) ⬆️
soap.go 71.42% <80%> (-1.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a53d7a4...2102ad9. Read the comment docs.

@tiaguinho
Copy link
Owner

Hi @highercomve,
Can you fix the problem with the tests?

Thank you

@highercomve
Copy link
Contributor Author

Yeah, I will I did some changes and I forget about the test.

@tiaguinho tiaguinho merged commit 84f9e16 into tiaguinho:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants