-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
route.get("/") #1648
Comments
Have you tried empty string ( |
That could work too but (IMO) looks strange. I think this is mostly a documentation issue |
FYI @tiangolo it looks like regex in the path is broken as of the latest release
now returns a 404. Could be related to a starlette change |
@curtiscook yeah I agree it looks strange, but It is supported only for those special cases but is not recommended. |
Yeah, I think the only thing to do here would be to update the docs to be a little more clear?
|
Hey @curtiscook, check out my solution here. The annotator-for-annotators solution should allow for you to enter use either "/" or "/foo" and have the alternative route included. |
Assuming the original need was handled, this will be automatically closed now. But feel free to add more comments or create new issues or PRs. |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
Hi,
Very small issue
In the docs it is recommended to do
for the base path on a router (or endpoint). However, this causes a 307 redirect to include the trailing slash, which is inconsistent with the standard behavior of no trailing slash.
You can work around the issue with
@route.get("/?") but @route.get() is unsupported
Maybe it would be helpful to
a) update the docs around this behavior
b) support @route.get() with no parameters ?
Why it's relevant: often times clients will drop headers on a redirect, which will drop the authorization header.
The text was updated successfully, but these errors were encountered: