Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable showCommonExtensions for Swagger UI #372

Closed
mktums opened this issue Jul 5, 2019 · 3 comments
Closed

Enable showCommonExtensions for Swagger UI #372

mktums opened this issue Jul 5, 2019 · 3 comments
Labels
answered confirmed feature New feature or request good first issue Good for newcomers reviewed

Comments

@mktums
Copy link

mktums commented Jul 5, 2019

Is your feature request related to a problem? Please describe.
Swagger UI doesn't render regex/min/max/etc if showCommonExtensions: true isn't present on Swagger UI initialization. https://swagger.io/docs/open-source-tools/swagger-ui/usage/configuration/

image

Describe the solution you'd like
Add

showExtensions: true,
showCommonExtensions: true,

after

fastapi/fastapi/openapi/docs.py

Line 31 in 195559c

url: '{openapi_url}',

Describe alternatives you've considered
…or let end-user configure it.
@mktums mktums added the feature New feature or request label Jul 5, 2019
@austinorr austinorr mentioned this issue Dec 28, 2019
Closed
@tiangolo
Copy link
Owner

Yeah, I think it would be a good idea to have those on by default.

Although I just tried locally and it really didn't seem to change the UI...

@tiangolo tiangolo added the good first issue Good for newcomers label Feb 10, 2020
@TiewKH TiewKH mentioned this issue May 24, 2020
Merged
@tiangolo
Copy link
Owner

This was solved in #1466 by @TiewKH ! 🚀

Available in FastAPI version 0.57.0 🎉

@github-actions
Copy link
Contributor

Assuming the original issue was solved, it will be automatically closed now. But feel free to add more comments or create new issues.

@mjhea0 mjhea0 mentioned this issue Dec 16, 2020
Closed
@tiangolo tiangolo changed the title [FEATURE] Enable showCommonExtensions for Swagger UI Enable showCommonExtensions for Swagger UI Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
answered confirmed feature New feature or request good first issue Good for newcomers reviewed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mktums @tiangolo