Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏️ Fix typo in dependencies with yield source examples #10847

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

tiangolo
Copy link
Member

✏️ Fix typo in dependencies with yield source examples

@tiangolo tiangolo added the docs Documentation about how to use FastAPI label Dec 26, 2023
@tiangolo tiangolo enabled auto-merge (squash) December 26, 2023 20:32
@tiangolo tiangolo merged commit dd790c3 into master Dec 26, 2023
37 checks passed
@tiangolo tiangolo deleted the typo-dependencies-with-yield branch December 26, 2023 20:37
@Jamim
Copy link
Contributor

Jamim commented Dec 27, 2023

Hello @tiangolo,

It's great that you fixed this! 🎉
However, there was a PR that already proposed the fix.

Why I'm pointing this out 🤔

I see that FastAPI, as an open-source project, sadly experiences a deep lack of maintenance. It has a great community that actively submitting, reviewing, and discussing PRs and reporting issues starting discussions (since there is no way to submit an issue with no privilege to do so). Meanwhile, there is no one else but you with write access to handle them. And this project obviously requires more time to invest that you alone can at the moment.

It would be great if you consider looking among the community for an additional maintainer.

Thanks for your attention! 🙇🏻‍♂️

@tiangolo
Copy link
Member Author

tiangolo commented Dec 27, 2023

Thanks @Jamim! Yep, I have a lot of PRs to review, but there were several features I had to handle myself first, like the refactor of the dependencies, and then the upgrades to Starlette (that was blocked by that). I noticed the typo in a comment somewhere else and fixed it quickly, but wasn't able to go through the PRs to see that someone had already proposed a fix (my bad 😬).

Of course, I would love all the maintainer help I can have! Would you like to help? There are several things to do, mainly answering questions in discussions and reviewing PRs (BTW, the count of PRs should exclude translations, I can't merge those unless there are 2 reviews from native speakers.). That takes a lot of work and bandwidth, and if it's not me alone, then I would have much more time to review the things that were already reviewed, merge PRs that are actually ready, and answer questions or fix bugs that have no other answer... for example, lots and lots of questions are actually errors from the user side, not problems in FastAPI, or the lack of reading the docs, the same for many PRs. Or there are many incomplete PRs, without tests, or that no one else pulled the changes and checked them locally.

Most of the big chunk of the "maintainer" work can be done by anyone that wants to help, all the instructions are in the docs:

https://fastapi.tiangolo.com/help-fastapi/#help-maintain-fastapi

@Jamim
Copy link
Contributor

Jamim commented Dec 27, 2023

Thank you for being so open on this topic! I really appreciate it! ❤️

Would you like to help?

Sure, I'm happy to be helpful, so I'll try to do it the way you suggested.

@urushio urushio mentioned this pull request Dec 27, 2023
nilslindemann pushed a commit to nilslindemann/fastapi that referenced this pull request Dec 27, 2023
I do it this way, so that I can keep reordering commits (doing it via the GitHub "sync fork" button breaks this feature)

Note that, because I do it like this, the GitHub GUI will assume that this branch is out of sync with the master branch. But that's not the case, this branch is in sync.

📝 Restructure Docs section in Contributing page (fastapi#10844)

📝 Restructure Docs section in Contributing page

📝 Update release notes

📝 Add docs: Node.js script alternative to update OpenAPI for generated clients (fastapi#10845)

📝 Update release notes

⬆️ Upgrade Starlette to 0.28.0 (fastapi#9636)

Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>

📝 Update release notes

🔖 Release version 0.107.0

⬆️ Upgrade Starlette to `>=0.29.0,<0.33.0`, update docs and usage of templates with new Starlette arguments (fastapi#10846)

* 📝 Update docs for compatibility with Starlette 0.29.0 and new template arguments

* ⬆️ Upgrade Starlette to >=0.29.0,<0.33.0

* 📌 Remove AnyIO pin

📝 Update release notes

🔖 Release version 0.108.0

✏️ Fix typo in dependencies with yield source examples (fastapi#10847)

📝 Update release notes

✏️ Fix typo in release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation about how to use FastAPI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants