Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chinese translation for index docs #1191

Merged
merged 6 commits into from
May 16, 2020
Merged

Conversation

waynerv
Copy link
Contributor

@waynerv waynerv commented Mar 31, 2020

We (a small team) are working to complete the doc translation of Chinese version in the next two months.

@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #1191 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1191   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          224       226    +2     
  Lines         6728      6785   +57     
=========================================
+ Hits          6728      6785   +57     
Impacted Files Coverage Δ
fastapi/routing.py 100.00% <0.00%> (ø)
fastapi/encoders.py 100.00% <0.00%> (ø)
fastapi/applications.py 100.00% <0.00%> (ø)
tests/test_skip_defaults.py 100.00% <0.00%> (ø)
tests/test_jsonable_encoder.py 100.00% <0.00%> (ø)
..._tutorial/test_sql_databases/test_sql_databases.py 100.00% <0.00%> (ø)
...est_sql_databases/test_sql_databases_middleware.py 100.00% <0.00%> (ø)
...test_application_configuration/test_tutorial001.py
tests/test_tutorial/test_settings/test_app02.py 100.00% <0.00%> (ø)
...orial/test_sql_databases/test_testing_databases.py 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e1cd45...f614829. Read the comment docs.

@RunningIkkyu
Copy link
Contributor

@waynerv I'm working on the Chinese trans too, may I have your wechat or email?

Copy link
Contributor

@RunningIkkyu RunningIkkyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great translations! @waynerv

docs/zh/docs/index.md Outdated Show resolved Hide resolved
docs/zh/docs/index.md Outdated Show resolved Hide resolved
docs/zh/docs/index.md Outdated Show resolved Hide resolved
docs/zh/docs/index.md Outdated Show resolved Hide resolved
docs/zh/docs/index.md Show resolved Hide resolved
docs/zh/docs/index.md Outdated Show resolved Hide resolved
docs/zh/docs/index.md Outdated Show resolved Hide resolved
@waynerv
Copy link
Contributor Author

waynerv commented Mar 31, 2020

@RunningIkkyu Great! You can send your wechat to my gmail: ampedee@gmail.com. I will contact you later.

docs/zh/docs/index.md Outdated Show resolved Hide resolved
docs/zh/docs/index.md Outdated Show resolved Hide resolved
docs/zh/docs/index.md Outdated Show resolved Hide resolved
docs/zh/docs/index.md Outdated Show resolved Hide resolved
docs/zh/docs/index.md Outdated Show resolved Hide resolved
docs/zh/docs/index.md Outdated Show resolved Hide resolved
@llxlr
Copy link

llxlr commented Apr 1, 2020

天哪,有翻译的人了,我也自己开了个翻译项目,我感觉自己在做无用功

@Dustyposa
Copy link
Contributor

天哪,有翻译的人了,我也自己开了个翻译项目,我感觉自己在做无用功

has interested in join our team? my email zmzposa@outlook.com

@tiangolo
Copy link
Member

tiangolo commented Apr 1, 2020

This is amazing! Thanks everyone for doing this! 🚀 🌏 💬

And special thanks for the reviews from others, that's key here, as I don't know Chinese 😅

When others feel like this is complete, that there are no more corrections necessary, and hopefully that the style of "conversation" is similar, please add a new review approving the changes of this PR.

That way, after seeing that there's some consensus on the translation I'll be able to merge it. 🎉

@tiangolo
Copy link
Member

@Dustyposa do you think this is ready? You can let me know with a review approving it 😄 👍

@phy25 if you have the chance, could you help me with a review here?

I'm just waiting for more reviews approving it before merging. 🌐 🚀

@waynerv
Copy link
Contributor Author

waynerv commented Apr 20, 2020

@tiangolo I can ask the Chinese community for some help. More and more Chinese developers have started to use FastAPI recently.

Copy link
Contributor

@lpdswing lpdswing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked, i approve this

@tiangolo tiangolo merged commit bfa78db into fastapi:master May 16, 2020
@tiangolo
Copy link
Member

This is awesome! 🚀 🌏 🙇

Thanks for all the work @waynerv ! 🍰 👏 🎉

Thanks for the reviews and comments @RunningIkkyu , @Dustyposa , @lpdswing , @jamesyangget 💪 🤓 🙇 🍰

hyahiaoui pushed a commit to hyahiaoui/fastapi that referenced this pull request Aug 1, 2020
* Add Chinese tranlation for docs/index.md

* Fix syntax issue

* Update resource address of zh docs

* Optimize typography in zh docs

* improve translations

Co-authored-by: Waynerv <wei.xie@woqutech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants