Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update database setup for tests #1226

Merged
merged 2 commits into from
Apr 8, 2020
Merged

Update database setup for tests #1226

merged 2 commits into from
Apr 8, 2020

Conversation

tiangolo
Copy link
Member

@tiangolo tiangolo commented Apr 8, 2020

🗃️ Update database setup for tests.

Related to #1221

@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #1226 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1226   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          226       226           
  Lines         6783      6785    +2     
=========================================
+ Hits          6783      6785    +2     
Impacted Files Coverage Δ
..._tutorial/test_sql_databases/test_sql_databases.py 100.00% <100.00%> (ø)
...est_sql_databases/test_sql_databases_middleware.py 100.00% <100.00%> (ø)
...orial/test_sql_databases/test_testing_databases.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4405bb...93b4e13. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2020

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2020

@tiangolo tiangolo merged commit a46bbc5 into master Apr 8, 2020
@tiangolo tiangolo deleted the handle-setup-dbs branch April 8, 2020 05:42
@samuelcolvin
Copy link
Collaborator

Thanks so much.

Regarding the many "🚀 Deployed on" comments, if you setup the deploy as a separate job in github CI, you can use normal commit statuses rather than comments.

Have a look at pydantic - it's a bit more complicated as I got pissed off with netlify, but it explains the idea.

hyahiaoui pushed a commit to hyahiaoui/fastapi that referenced this pull request Aug 1, 2020
* 🗃️ Update database setup for tests

* ✅ Add pragmas and update db handling for tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants