Cannot import ''OAuth2PasswordRequestFormStrict''

[RichardHoekstra]

Fixes an import error:

from fastapi.security import OAuth2PasswordBearer, OAuth2PasswordRequestFormStrict
ImportError: cannot import name 'OAuth2PasswordRequestFormStrict'

Currently using the workaround:
from fastapi.security.oauth2 import OAuth2PasswordRequestFormStrict

Not sure whether the maintainers intended for the import to be different from the rest of the security imports. I assume this is a simple oversight.

[codecov]

Codecov Report

Merging #1462 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1462   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          227       227           
  Lines         6807      6808    +1     
=========================================
+ Hits          6807      6808    +1     

Impacted Files	Coverage Δ
fastapi/security/__init__.py	100.00% <ø> (ø)
tests/test_security_oauth2.py	100.00% <100.00%> (ø)
tests/test_security_oauth2_optional.py	100.00% <100.00%> (ø)
fastapi/utils.py	100.00% <0.00%> (ø)
fastapi/openapi/utils.py	100.00% <0.00%> (ø)
fastapi/dependencies/utils.py	100.00% <0.00%> (ø)
...test_tutorial/test_path_params/test_tutorial005.py	100.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98bb9f1...694cb3e. Read the comment docs.

[phy25]

You may also want to change the corresponding documentation as well.

[RichardHoekstra]

You may also want to change the corresponding documentation as well.

I would but I don't know what corresponds.

[phy25]

https://github.com/tiangolo/fastapi/search?q=OAuth2PasswordRequestFormStrict

[ghost]

I always found it weird that the strict version was not exported, I think this is a good improvement. 👍

[tiangolo]

Thanks for your contribution @RichardHoekstra ! 🚀

So, it was actually intentional, I would expect (and suggest) everyone to use the non-strict version, as the strict version enforces clients to send a constant value doesn't add much, as it's just a constant.

Because of that, I didn't expose it directly.

But... I think this is like the 3th PR suggesting that change 😂

So I guess it's gonna be more intuitive if it's just there even though I don't expect many people to use it.

Thanks for the review @phy25 ! 🙇