Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏ Fix typos in docs and source examples #2102

Merged
merged 4 commits into from
Nov 5, 2020
Merged

✏ Fix typos in docs and source examples #2102

merged 4 commits into from
Nov 5, 2020

Conversation

AdrianDeAnda
Copy link
Contributor

Fixing some typos on async.md, unzip-docs.sh and test_multipart_installation.py that I encountered while checking the source code.

@codecov
Copy link

codecov bot commented Sep 26, 2020

Codecov Report

Merging #2102 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2102   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          240       240           
  Lines         7101      7101           
=========================================
  Hits          7101      7101           
Impacted Files Coverage Δ
tests/test_multipart_installation.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccd3b97...8ded25b. Read the comment docs.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 020637e0f1974fb8d7d93767dc46233527dc4c56 at: https://5f6fcad44936ac869a449639--fastapi.netlify.app

@AdrianDeAnda
Copy link
Contributor Author

@tiangolo Added no coverage on some tests as my typo changes might have triggered the codecov check on files that had not been checked in a while.

@github-actions
Copy link
Contributor

📝 Docs preview for commit f7b75bc7077f12b71d34cc05beb9b303f9d9ca6c at: https://5f6ff5792785769c10d089f3--fastapi.netlify.app

@ycd
Copy link
Contributor

ycd commented Sep 27, 2020

Great catch. also jfyk last commit is duplicate of #2038.

Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🔍 🕵️

These 2 no cover are not necessary as Codecov takes the coverage from the tests running in all Python versions.

The only disadvantage is that running locally in a single Python version coverage will never be at 100% for that file, but 🤷

fastapi/concurrency.py Outdated Show resolved Hide resolved
fastapi/concurrency.py Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2020

📝 Docs preview for commit 8ded25b at: https://5fa478c3b14d582e07d34287--fastapi.netlify.app

@tiangolo tiangolo changed the title Fixing some typos ✏ Fix typos in docs and source examples Nov 5, 2020
@tiangolo tiangolo merged commit 75c64b6 into fastapi:master Nov 5, 2020
@tiangolo
Copy link
Member

tiangolo commented Nov 5, 2020

Thanks! Good catch! 🔍 ☕

And thanks @ycd for the help here! 🙇

@AdrianDeAnda AdrianDeAnda deleted the fix-some-typos branch March 5, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants