-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✏ Fix typos in docs and source examples #2102
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2102 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 240 240
Lines 7101 7101
=========================================
Hits 7101 7101
Continue to review full report at Codecov.
|
📝 Docs preview for commit 020637e0f1974fb8d7d93767dc46233527dc4c56 at: https://5f6fcad44936ac869a449639--fastapi.netlify.app |
📝 Docs preview for commit f7b75bc7077f12b71d34cc05beb9b303f9d9ca6c at: https://5f6ff5792785769c10d089f3--fastapi.netlify.app |
Great catch. also jfyk last commit is duplicate of #2038. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 🔍 🕵️
These 2 no cover
are not necessary as Codecov takes the coverage from the tests running in all Python versions.
The only disadvantage is that running locally in a single Python version coverage will never be at 100% for that file, but 🤷
📝 Docs preview for commit 8ded25b at: https://5fa478c3b14d582e07d34287--fastapi.netlify.app |
Thanks! Good catch! 🔍 ☕ And thanks @ycd for the help here! 🙇 |
Fixing some typos on
async.md
,unzip-docs.sh
andtest_multipart_installation.py
that I encountered while checking the source code.