Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Bump Uvicorn max range to 0.15.0 #3345

Merged
merged 4 commits into from
Oct 5, 2021
Merged

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Jun 8, 2021

EDIT: We probably want to add asgiref as dependency and use its types.

@jedidiahhorne
Copy link

awesome, thanks guys!

@musicinmybrain
Copy link
Contributor

I have no influence over the FastAPI project, but:

  • Consider bumping the maximum uvicorn dependency in the dev extra to match the all extra.
  • Also, uvicorn 0.15.0 is now released. Can it be safely allowed too?

@codecov
Copy link

codecov bot commented Sep 11, 2021

Codecov Report

Merging #3345 (50de820) into master (284eb66) will increase coverage by 5.63%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #3345      +/-   ##
===========================================
+ Coverage   94.36%   100.00%   +5.63%     
===========================================
  Files         478       410      -68     
  Lines       12324     10281    -2043     
===========================================
- Hits        11629     10281    -1348     
+ Misses        695         0     -695     
Impacted Files Coverage Δ
fastapi/utils.py 100.00% <0.00%> (ø)
..._tutorial/test_sql_databases/test_sql_databases.py 100.00% <0.00%> (ø)
...orial/test_sql_databases/test_testing_databases.py 100.00% <0.00%> (ø)
...torial/test_query_params/test_tutorial006_py310.py
docs_src/sql_databases/sql_app_py39/alt_main.py
.../test_tutorial/test_body/test_tutorial001_py310.py
...rial/test_sql_databases/test_sql_databases_py39.py
docs_src/sql_databases/sql_app_py39/crud.py
...ry_params_str_validations/test_tutorial011_py39.py
...c/sql_databases/sql_app_py39/tests/test_sql_app.py
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 284eb66...50de820. Read the comment docs.

@Kludex
Copy link
Member Author

Kludex commented Sep 11, 2021

Thanks for the review @musicinmybrain :)

@github-actions
Copy link
Contributor

📝 Docs preview for commit 9c0c080 at: https://613c6127c187a655d8a62524--fastapi.netlify.app

@tiangolo tiangolo changed the title ⬆️ Bump uvicorn max range to 0.15.0 ⬆️ Bump Uvicorn max range to 0.15.0 Oct 5, 2021
@tiangolo
Copy link
Member

tiangolo commented Oct 5, 2021

Great, thanks @Kludex! 🍰

For now, I would prefer not to add a dependency on asgiref only for the types (asgiref as a bunch of other tools apart from the types), and as ASGI is just dicts everywhere I would think we should be able to get the annotations right.

Thanks everyone else for the comments too! ☕

This is included in FastAPI 0.68.3, just released. 🎉

@tiangolo tiangolo merged commit 2680f36 into fastapi:master Oct 5, 2021
@Kludex
Copy link
Member Author

Kludex commented Oct 5, 2021

The thing is that Starlette is too generic on its ASGI types, and uvicorn is strict now.

In any case, FastAPI shouldn't care about asgiref, I'm going to take care on Starlette.

@tiangolo
Copy link
Member

tiangolo commented Oct 5, 2021

In any case, FastAPI shouldn't care about asgiref, I'm going to take care on Starlette.

Woohoo! Nice 🎉 😎 🤓

@Kludex Kludex deleted the patch-1 branch November 10, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants