Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Korean translation for docs/tutorial/response-status-code.md #3742

Merged
merged 20 commits into from
Dec 8, 2021

Conversation

NinaHwang
Copy link
Contributor

@NinaHwang NinaHwang commented Aug 21, 2021

This PR translates tutorial/response-status-code.md in Korean.

related: #2017

Copy link
Contributor

@hard-coders hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome aboard 🎉
It seems perfect to me!

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels Oct 5, 2021
@github-actions github-actions bot mentioned this pull request Oct 5, 2021
Copy link
Contributor

@0417taehyun 0417taehyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to remove the supplementary explanation by using () and English in it.

Feel free to check my reviews. Big appreciate your works and great honor to check it 🚀

docs/ko/docs/tutorial/response-status-code.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/response-status-code.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/response-status-code.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/response-status-code.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/response-status-code.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/response-status-code.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/response-status-code.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/response-status-code.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/response-status-code.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/response-status-code.md Outdated Show resolved Hide resolved
NinaHwang and others added 8 commits November 28, 2021 13:06
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Nov 28, 2021

Codecov Report

Merging #3742 (3751456) into master (f7d7c6c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #3742   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          409       409           
  Lines        10244     10264   +20     
=========================================
+ Hits         10244     10264   +20     
Impacted Files Coverage Δ
fastapi/routing.py 100.00% <0.00%> (ø)
fastapi/concurrency.py 100.00% <0.00%> (ø)
fastapi/dependencies/utils.py 100.00% <0.00%> (ø)
.../test_tutorial/test_websockets/test_tutorial002.py 100.00% <0.00%> (ø)
tests/test_fakeasync.py
tests/test_read_with_orm_mode.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7d7c6c...3751456. Read the comment docs.

NinaHwang and others added 9 commits November 28, 2021 13:07
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@github-actions
Copy link
Contributor

📝 Docs preview for commit 3751456 at: https://61a302a962d57af234a90a8a--fastapi.netlify.app

Copy link
Contributor

@0417taehyun 0417taehyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@tiangolo tiangolo merged commit 39dbee9 into fastapi:master Dec 8, 2021
@tiangolo
Copy link
Member

tiangolo commented Dec 8, 2021

Awesome, thank you @NinaHwang! 🙇 🍰

And thanks for the reviews @hard-coders and @0417taehyun! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-2 lang-all Translations lang-ko Korean translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants