Fix union body #400
Merged
Fix union body #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #400 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 238 240 +2
Lines 5566 5626 +60
=====================================
+ Hits 5566 5626 +60
Continue to review full report at Codecov.
|
|
Thank you @koxudaxi ! Great job debugging and finding the problem. 🍰 🚀 I just updated the implementation a bit to avoid the internal declaration of a sub-function and added a couple of comments in the tests to clarify why |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fix union body bug.
Detail
FastAPI can't handle a body as union type.
I found parameter detected condition is wrong, which don't care union type.
Related issue
#300