Fix clone field implementation to handle sub-models #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
including tests
Codecov Report
@@ Coverage Diff @@
## master #889 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 292 293 +1
Lines 7665 7692 +27
=====================================
+ Hits 7665 7692 +27
Continue to review full report at Codecov.
|
This was referenced Jan 18, 2020
deuce2367
added a commit
to deuce2367/fastapi
that referenced
this pull request
Jan 20, 2020
…orators - create_model() is now called using a __base__ parameter vs. a __config__ parameter - isinstance comparisons now work as expected - unit test created for fastapi#889 still passes as before
deuce2367
added a commit
to deuce2367/fastapi
that referenced
this pull request
Jan 21, 2020
…orators - create_model() is now called using a __base__ parameter vs. a __config__ parameter - isinstance comparisons now work as expected - unit test created for fastapi#889 still passes as before - apply black formatting
deuce2367
added a commit
to deuce2367/fastapi
that referenced
this pull request
Jan 21, 2020
…corators
- create_model() is now called using a __base__ parameter vs. a __config__ parameter
- isinstance comparisons now work as expected
- unit test created for fastapi#889 still passes as before
- apply black formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Fix clone field implementation to handle sub-models including tests.
This should fix / related to #847 #800