Add rich print using _get_rich_console #509
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📝 Docs preview for commit 3b157c1 at: https://637b5b9082dd302494a34f0a--typertiangolo.netlify.app |
|
📝 Docs preview for commit 41e055f at: https://637bad2009b1d000aa0c4ef3--typertiangolo.netlify.app |
|
📝 Docs preview for commit 7aa8580 at: https://637ca37be26a2376b30fe6f5--typertiangolo.netlify.app |
|
@tiangolo I would appreciate a review on this one. cc @willmcgugan as the author of this module (and rich ❤️) We might want to change how we load the configuration such as |
feluelle
added a commit
to astronomer/astro-sdk
that referenced
this pull request
Nov 22, 2022
Instead of changing the stdout via get_stdout, we just set the TERMINAL_WIDTH to a very large number to avoid new lines. The configuration has been copied from https://github.com/tiangolo/typer/blob/master/scripts/test.sh **EDIT:** I have also created tiangolo/typer#509 to fix that in typer.
|
📝 Docs preview for commit a554497 at: https://637dec7bc6ae7d0db6b689fb--typertiangolo.netlify.app |
|
📝 Docs preview for commit a02e793 at: https://639ce9aa9c18df08c1c84069--typertiangolo.netlify.app |
|
@tiangolo please take a look - all tests have passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows using rich's print in typer context.
It uses the
_get_rich_consoleto make it more aware of the terminal it sits in. For example, this can be useful if you want to setTERMINAL_WIDTH.