Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin versions? #24

Closed
slhck opened this issue Jan 8, 2020 · 2 comments
Closed

Pin versions? #24

slhck opened this issue Jan 8, 2020 · 2 comments

Comments

@slhck
Copy link

slhck commented Jan 8, 2020

Would it make sense to pin the version of at least FastAPI (potentially the Uvicorn and Gunicorn as well) such that the images create reproducible builds?

I've ran into this often, where I define a specific version of this image (e.g. python3.7-2019-12-11), but whenever I build it, it just pulls the latest version of FastAPI, whatever that is at the time of building (due to RUN pip install fastapi). This may lead to inconsistencies between local versions (which I can specify in requirements.txt) and Docker builds.

@tiangolo
Copy link
Owner

You could pin the fastapi version in your own Dockerfile or you could remove the pip install fastapi and instead use your own requirements.txt file.

@github-actions
Copy link

Assuming the original issue was solved, it will be automatically closed now. But feel free to add more comments or create new issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants