Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker images out of date #53

Closed
jenswet opened this issue Jul 2, 2020 · 9 comments
Closed

Docker images out of date #53

jenswet opened this issue Jul 2, 2020 · 9 comments
Labels

Comments

@jenswet
Copy link

jenswet commented Jul 2, 2020

Hello,

the docker CI build is not triggered anymore and the images in the hub are out of date.

Would be great if they can be updated again @tiangolo

Thanks!

@rozacek
Copy link

rozacek commented Jul 7, 2020

I noticed the same problem.
Currently fastapi version in images is: 0.55.1 what is very confusing when goes on working with root_path feature: https://fastapi.tiangolo.com/advanced/behind-a-proxy/ as it's supported since 0.56.0!!! I lost a day due to that fact :(

@jenswet
Copy link
Author

jenswet commented Jul 28, 2020

@tiangolo Can you trigger a new build please?

@graue70
Copy link
Contributor

graue70 commented Oct 14, 2020

In the meantime, you can use this:

FROM tiangolo/uvicorn-gunicorn:python3.8

RUN PIP_NO_CACHE_DIR=1 \
    PIP_DISABLE_PIP_VERSION_CHECK=1 \
    pip install fastapi

# ...

COPY ./app /app

It is inspired by the original Dockerfile. Of course, it only works for uvicorn-gunicorn tags which are supported (particularly, it doesn't currently work for python 3.9 or for any python version with alpine higher than 3.10).

@Mazyod
Copy link

Mazyod commented Nov 10, 2020

Starlette samesite keyword argument on set_cookie is also missing due to outdated images. 🙇‍♂️

@tiangolo
Copy link
Owner

tiangolo commented Nov 9, 2022

Thanks for the discussion here everyone! I think this was triggered/handled a while ago, right?

Sorry for the long delay! 🙈 I wanted to personally address each issue/PR and they piled up through time, but now I'm checking each one in order.

@JayPalm
Copy link

JayPalm commented Nov 9, 2022

Thanks for the discussion here everyone! I think this was triggered/handled a while ago, right?

Sorry for the long delay! 🙈 I wanted to personally address each issue/PR and they piled up through time, but now I'm checking each one in order.

@tiangolo, is this an automated reply?

Don't think so. Appears that the Python3.9 release is still the latest image available, from over a year ago, but I'm no longer relying on this image, in favor of my own. I see there are recent commits to uvicorn-gunicorn repo however, including a 3.10 branch.

@github-actions github-actions bot removed the answered label Nov 9, 2022
@tiangolo
Copy link
Owner

tiangolo commented Nov 9, 2022

No, it's not an automated reply, the discussion was about new runs of the image builds, not Python versions.

And yep, indeed, you should probably rely on your own image, you probably don't need this one as explained in the README: https://github.com/tiangolo/uvicorn-gunicorn-fastapi-docker#-warning-you-probably-dont-need-this-docker-image

I'm glad you found a solution for your use cases. 👍

@JayPalm
Copy link

JayPalm commented Nov 9, 2022

the discussion was about new runs of the image builds, not Python versions.

Yup, egg on my face. Was distracted as to the subject mater I guess. Cheers.

@github-actions
Copy link

Assuming the original issue was solved, it will be automatically closed now. But feel free to add more comments or create new issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants