Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add support for grouping external status checks #725

Open
kevinheins opened this issue Jan 11, 2022 · 1 comment
Open

[FEAT] Add support for grouping external status checks #725

kevinheins opened this issue Jan 11, 2022 · 1 comment
Labels
feature New feature or request

Comments

@kevinheins
Copy link

Is your feature request related to a problem? Please describe.
I have an external CI system (TeamCity) that reports status of commits back to a Github PR. These are considered statuses and not checks. The check-group app doesn't consider these statuses when collection checks.

Describe the solution you'd like
check-group can support external status inside sub-projects.

@kevinheins kevinheins added the feature New feature or request label Jan 11, 2022
@tianhaoz95
Copy link
Owner

Thanks for pointing out this use case. From the doc https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#status, it seem to contain all the information to perform the work.

Technically speaking, it won't be too hard to add this since we only need to add one more type of webhook to listen to and maybe slightly modify the parser.

2 considerations I have on top of my mind are: 1) how much traffic will it add for a repository that don't intentionally use statuses (maybe there are some GitHub statuses like GH pages), we might want to make it user configurable or filter the event somehow. 2) if it will be a bit confusing for users to define statuses the same way as check runs in the configuration file.

I will think a bit more about the 2 listed before adding a plan to support the use case.

If you have any good suggestions, please feel free to comment here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants