Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the current code, spectral normalization does not seem to be properly applied #3

Closed
dlqudwns opened this issue Sep 9, 2020 · 1 comment

Comments

@dlqudwns
Copy link

dlqudwns commented Sep 9, 2020

When adding FC layer, BNN class adds copy of layer, according to

https://github.com/tianheyu927/mopo/blob/master/mopo/models/bnn.py#L141

Further, when copying a layer, the code uses repr function:
https://github.com/tianheyu927/mopo/blob/master/mopo/models/fc.py#L132
https://github.com/tianheyu927/mopo/blob/master/mopo/models/fc.py#L51

However, the sn attribute is not specified in repr, and it uses default value sn=False.

Even if I add sn in the repr, tensorflow gives error due to the redundant name 'u'.

@tianheyu927
Copy link
Owner

Hi ByungJun,

Thanks for catching that! Spectral normalization is indeed not properly applied in the code. We have updated the code to remove the spectral normalization and will update the paper to exclude the discussion on using Lipschitz regularization in the practical algorithm as soon as possible. Note that Lipschitz regularization on the model is mainly a regularization heuristic and removing it won’t affect the soundness of the paper. Sorry for the confusion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants