-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --ignore functionality #7
Comments
sure no problem! I love to see your new feature! |
Hi, I have added in the feature while still allowing the original features to work, including checking multiple files with -ignore, please add my fork as remote. My Fork: https://github.com/Wei-J-Huang/urlStatusChecker.git Let me know what you think about the updates! |
can you please check, it is not working properly when I am testing. |
I figured out why. Because your solution only checks all the lines startWith "http" and "https". Could you please use regex for that? And we should treat # as a comment which shouldn't ignore the URLs after '#'. We can discuss it on Slack or WeChat if you wish. Thanks! |
Could you let me know your name on slack please? I wasn’t able to find you, thanks. |
|
I just sent a direct message to you on slack . I am Junyong Liu |
Hello, I would like to work on your project to add lab 4 functionality, i.e adding ignore URL functionality.
The text was updated successfully, but these errors were encountered: