Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --ignore functionality #7

Closed
Wei-J-Huang opened this issue Oct 18, 2020 · 7 comments
Closed

Add --ignore functionality #7

Wei-J-Huang opened this issue Oct 18, 2020 · 7 comments
Assignees

Comments

@Wei-J-Huang
Copy link
Contributor

Hello, I would like to work on your project to add lab 4 functionality, i.e adding ignore URL functionality.

@tianlangwu
Copy link
Owner

sure no problem! I love to see your new feature!

@Wei-J-Huang
Copy link
Contributor Author

Wei-J-Huang commented Oct 18, 2020

Hi, I have added in the feature while still allowing the original features to work, including checking multiple files with -ignore, please add my fork as remote.

My Fork: https://github.com/Wei-J-Huang/urlStatusChecker.git
Branch Name: issue-7

Let me know what you think about the updates!

@tianlangwu
Copy link
Owner

can you please check, it is not working properly when I am testing.
Both test1.html and test3.txt has the same contain "http://s9y.org" but it didnt ignore.
let me know if I did anything wrong?
Screenshot 2020-10-18 102952

@tianlangwu
Copy link
Owner

tianlangwu commented Oct 18, 2020

I figured out why. Because your solution only checks all the lines startWith "http" and "https". Could you please use regex for that?
Could you please add those from the instruction as well? "If the file isn't valid, give an appropriate error message and exit? Otherwise, use the file's URL patterns to test all the URLs being processed, skipping any that match."

And we should treat # as a comment which shouldn't ignore the URLs after '#'.

We can discuss it on Slack or WeChat if you wish. Thanks!

@Wei-J-Huang
Copy link
Contributor Author

Could you let me know your name on slack please? I wasn’t able to find you, thanks.

@tianlangwu
Copy link
Owner

Could you let me know your name on slack please? I wasn’t able to find you, thanks.

@tianlangwu
Copy link
Owner

tianlangwu commented Oct 18, 2020

I just sent a direct message to you on slack . I am Junyong Liu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants