Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hashable instance for Fingerprint #156

Closed
andrewthad opened this issue May 27, 2018 · 3 comments
Closed

Hashable instance for Fingerprint #156

andrewthad opened this issue May 27, 2018 · 3 comments

Comments

@andrewthad
Copy link
Contributor

We've already got a Hashable instance for TypeRep. Having one for Fingerprint would be handy too.
@treeowl
Copy link

treeowl commented Oct 31, 2018

Agreed. Note that the instance for TypeRep doesn't actually salt properly:

forall (s1 :: Salt) (s2 :: Salt).
hashWithSalt s1 = hashWithSalt s2

I suppose the logic here is that there should be few enough collisions for HashMap purposes using just one of the words of the Fingerprint?

@treeowl
Copy link

treeowl commented Oct 31, 2018

Actually.... that logic applies to TypeRep fingerprints, but I'm not sure it applies to fingerprints in general. Are the two words sometimes independent?

treeowl added a commit to treeowl/hashable that referenced this issue Oct 31, 2018
@treeowl
Add a Hashable instance for Fingerprint
e098c2d 
Resolves haskell-unordered-containers#156
@treeowl treeowl mentioned this issue Oct 31, 2018
Closed
@hvr
Copy link
Collaborator

hvr commented May 5, 2019

Resolved by #157

@hvr hvr closed this as completed May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a Hashable instance for Fingerprint treeowl/hashable
3 participants
@hvr @treeowl @andrewthad