Hashable instances fix #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't pass as instance Hashable (HashMap k v) violates
(x == y) ==> hashWithSalt salt x == hashWithSalt salt y
property.
phadej
force-pushed
the
hashable-instances-fix
branch
from
94c4a3c
to
0a13436
Compare
|
Resolves #78 |
| pHashable xs is salt = | ||
| x == y ==> hashWithSalt salt x === hashWithSalt salt y | ||
| where | ||
| ys = L.map snd . L.sort . L.zip (is ++ [L.maximum (0:is) + 1..]) $ xs |
There was a problem hiding this comment.
Could you add a comment what this line is trying to achieve (e.g. would it be better to randomly shuffle ys)?
There was a problem hiding this comment.
I actually to randomly shuffle xs into ys, I'll give that shuffle stuff a name and a comment
|
Clarified the test. I don't know better way to have a list and randomly shuffled version of it for the property. |
|
@tibbe Is there something still needing a fix or an improvement? |
| go :: Int -> [HashMap k v] -> Int | ||
| go s [] = s | ||
| go s (Leaf _ l : tl) = s `hashLeafWithSalt` l `go` tl | ||
| -- For collisions we hashmix hash value, and then array of values' hashes sorted |
There was a problem hiding this comment.
Please keep line length <= 80 chars. Here and elsewhere.
phadej
force-pushed
the
hashable-instances-fix
branch
from
05a2554
to
69151b7
Compare
|
All lines are under 80 characters now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be ready to review.