IsList instances for GHC ≥ 7.8 #79
Conversation
| @@ -433,11 +440,14 @@ insertWith f k0 v0 m0 = go h0 k0 v0 0 m0 | |||
| {-# INLINABLE insertWith #-} | |||
|
|
|||
| -- | In-place update version of insertWith | |||
| unsafeInsertWith :: (Eq k, Hashable k) => (v -> v -> v) -> k -> v -> HashMap k v | |||
| unsafeInsertWith :: forall k v. (Eq k, Hashable k) | |||
There was a problem hiding this comment.
Why these changes? They don't seem related.
There was a problem hiding this comment.
Oh, right, I meant to say; sorry.
Turning on type families seemed to interfere with the type inference for the ST stuff, so I had to add some extra signatures for those.
There was a problem hiding this comment.
Do you know why this is? Is it documented somewhere?
There was a problem hiding this comment.
Aha! Type families imply MonoLocalBinds. So the s variables aren't polymorphic enough without an explicit signature and everything goes pear shaped.
The relevant manual section is http://www.haskell.org/ghc/docs/latest/html/users_guide/other-type-extensions.html#mono-local-binds.
|
Also, while I'm remembering things I should've mentioned (again, sorry): I wasn't sure whether the version checks should be |
|
Now when 7.8 is out I don't think we need to add it for 7.7. |
|
Could you make a release for this? |
|
@feuerbach released as 0.2.5.0. |
|
Thanks! |
For the
OverloadedListsextension.