Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MQTT trigger deadlocks if replyTo is empty #118

Closed
torresashjian opened this issue Sep 7, 2017 · 2 comments
Closed

MQTT trigger deadlocks if replyTo is empty #118

torresashjian opened this issue Sep 7, 2017 · 2 comments
Assignees
@torresashjian
Labels
kind/bug priority/P0
Milestone
0.4.2

Comments

@torresashjian
Copy link
Contributor

We need to add the right checks and a timeout for the publish message after calling the flow.
@torresashjian torresashjian self-assigned this Sep 7, 2017
@torresashjian torresashjian modified the milestones: 0.4.1, 0.4.2 Sep 7, 2017
@torresashjian
Copy link
Contributor Author

Fixed

@mgdevstack
Copy link

I have checked MQTT trigger implementation code base but there is no statement which actually updates StartRequest.RepyTo struct field. This is the reason we face Warning: Invalid empty topic to publish to and desired result is not retrieved (flow deadlock).

@torresashjian, plz have look at PR #144.

torresashjian added a commit that referenced this issue Nov 3, 2017
@torresashjian
Merge pull request #144 from mgdevstack/issue-118
219d61e 

issue #118 replyTo attribute updated to remove flow deadlock
Thanks @mgdevstack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@torresashjian torresashjian

Labels
kind/bug priority/P0
Projects
None yet
Milestone
0.4.2
Development

No branches or pull requests
2 participants
@torresashjian @mgdevstack